Issue 1774015: Bring r4503 to the 2.1 branch....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1774015: Bring r4503 to the 2.1 branch.... (Closed)

Created:
10 years, 7 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein, Kasper Lund, Mads Ager (chromium)

CC:
v8-dev, Lei Zhang, laforge

Base URL:
http://v8.googlecode.com/svn/branches/2.1/

Visibility:
Public.

Description

Bring r4503 to the 2.1 branch. Current custom call generators cannot cope with the case when receiver is not a JSArray. Add a support for bailout from custom call generators (just return undefined). BUG=684, 42802 Committed: http://code.google.com/p/v8/source/detail?r=4553

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -2 lines)			Patch
M	src/ia32/stub-cache-ia32.cc	View	3 chunks	+15 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/array-pop.js	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/mjsunit/array-push.js	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

Guys, sorry for a long list, I just would like to see that committed asap.

10 years, 7 months ago (2010-04-29 20:39:41 UTC) #1

LGTM

Expand Messages | Collapse Messages