Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1773963002: git-cl-try: print proper access denied error msg (Closed)

Created:
4 years, 9 months ago by nodir
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git-cl-try: print proper access denied error msg git-cl-try does not properly print error message when the response status code is 403, because response parsing is broken. Fix response parsing. R=sheyang@chromium.org, tandrii@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M git_cl.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nodir
PTAL
4 years, 9 months ago (2016-03-07 23:58:37 UTC) #1
sheyang
lgtm
4 years, 9 months ago (2016-03-08 00:18:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773963002/1
4 years, 9 months ago (2016-03-08 00:31:42 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 00:33:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299137

Powered by Google App Engine
This is Rietveld 408576698