Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1773943003: Roll src/breakpad/src/ 3be2dc8..481608d28 (Closed)

Created:
4 years, 9 months ago by michaelbai
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/breakpad/src/ 3be2dc8..481608d28. https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/3be2dc8..481608d28 Note: the DEPS shows a change from 7fef95a3 rather than 3be2dc8. This is due to the breakpad history rewrite happened in crbug.com/589297. 3be2dc8 is the commit-ish corresponding to 7fef95a3 in the rewritten history. $ git log 7fef95a32..481608d28 --date=short --no-merges --format='%ad %ae %s' 2016-03-08 primiano Don't merge the mappings if their exec bit are different. 2016-03-03 domlaskowski Add an optional root prefix to Linux dumpers 2016-02-26 mmandlis Handle multiple microdumps in system log. 2016-02-18 mmandlis Support processing microdumps for x86 architecture. 2016-02-17 birunthan Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails 2016-02-17 ted Fix buffer overrun in MinidumpModule::debug_identifier with MDCVInfoELF 2016-02-16 ivanpe Fixing a flaky Linux exploitability unittest. 2016-02-12 ted Ensure Linux minidump writer flushes minidump header early. 2016-02-11 mmandlis Parse additional line introduced in the microdump format and containing the GPU infromation in the following format: G GL_VERSION|GL_VENDOR|GL_RENDERER. 2016-02-10 thestig Revert "Added a switch to dump minidump modules in minidump_stackwalk." 2016-02-10 ted Change MDCVInfoELF into something usable. BUG=585534 Committed: https://crrev.com/d2f3d524b73e4a774bcfeabb9e14f524c0177471 Cr-Commit-Position: refs/heads/master@{#380391}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773943003/1
4 years, 9 months ago (2016-03-08 19:51:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 21:25:06 UTC) #5
michaelbai
PTAL
4 years, 9 months ago (2016-03-08 21:30:45 UTC) #7
Primiano Tucci (use gerrit)
On 2016/03/08 21:30:45, michaelbai wrote: > PTAL Hold on, there is something weird in this ...
4 years, 9 months ago (2016-03-08 23:04:59 UTC) #8
Primiano Tucci (use gerrit)
On 2016/03/08 23:04:59, Primiano wrote: > On 2016/03/08 21:30:45, michaelbai wrote: > > PTAL > ...
4 years, 9 months ago (2016-03-08 23:12:12 UTC) #9
michaelbai
On 2016/03/08 23:12:12, Primiano wrote: > On 2016/03/08 23:04:59, Primiano wrote: > > On 2016/03/08 ...
4 years, 9 months ago (2016-03-08 23:16:33 UTC) #10
Primiano Tucci (use gerrit)
On 2016/03/08 23:16:33, michaelbai wrote: > On 2016/03/08 23:12:12, Primiano wrote: > > On 2016/03/08 ...
4 years, 9 months ago (2016-03-08 23:29:46 UTC) #12
vapier
as mentioned via e-mail, the history isn't corrupt ... we partly rewrote it to expunge ...
4 years, 9 months ago (2016-03-08 23:58:14 UTC) #14
Primiano Tucci (use gerrit)
On 2016/03/08 23:58:14, vapier wrote: > as mentioned via e-mail, the history isn't corrupt ...
4 years, 9 months ago (2016-03-09 01:29:02 UTC) #15
vapier
i can't comment on breakpad/src/ as it's an automatic read-only mirror, but the main breakpad ...
4 years, 9 months ago (2016-03-09 05:28:43 UTC) #16
Primiano Tucci (use gerrit)
On 2016/03/09 05:28:43, vapier wrote: > i can't comment on breakpad/src/ as it's an automatic ...
4 years, 9 months ago (2016-03-09 10:00:27 UTC) #17
michaelbai
On 2016/03/09 10:00:27, Primiano wrote: > On 2016/03/09 05:28:43, vapier wrote: > > i can't ...
4 years, 9 months ago (2016-03-09 19:38:08 UTC) #18
Primiano Tucci (use gerrit)
3be2dc8..481608d28 is just 11 commits. But if you count the real commits from the current ...
4 years, 9 months ago (2016-03-09 20:47:34 UTC) #19
michaelbai
PTAL
4 years, 9 months ago (2016-03-09 21:46:58 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773943003/20001
4 years, 9 months ago (2016-03-09 21:47:26 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:09:26 UTC) #26
Primiano Tucci (use gerrit)
LGTM. I took the liberty to add a note about the history rewrite in the ...
4 years, 9 months ago (2016-03-10 12:04:00 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773943003/20001
4 years, 9 months ago (2016-03-10 12:04:31 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 12:09:02 UTC) #32
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 12:10:19 UTC) #34
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2f3d524b73e4a774bcfeabb9e14f524c0177471
Cr-Commit-Position: refs/heads/master@{#380391}

Powered by Google App Engine
This is Rietveld 408576698