Enable all Android builders to use 'chrome_with_codecs'.

tools/mb/mb_config.pyl

Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index 7f462d04501838b9c20029480870054f1897aec1..837b80c440baae279d3d85d116201c0e08d0f20d 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -11,18 +11,17 @@
   'configs': {
     'android_cast_gyp_debug_static_bot': ['android', 'cast', 'gyp', 'debug_static_bot'],
     'android_clang_asan_gyp_debug_bot': ['android', 'clang', 'asan', 'gyp', 'debug_bot'],
-    'android_gn_debug_bot': ['android', 'chrome_with_codecs', 'gn', 'debug_bot'],
-    'android_gn_debug_static_bot': ['android', 'chrome_with_codecs', 'gn', 'debug_static_bot'],
-    'android_gn_debug_static_bot_arm64': ['android', 'chrome_with_codecs', 'gn', 'debug_static_bot', 'arm64'],
-    'android_gn_debug_static_bot_mipsel': ['android', 'chrome_with_codecs', 'gn', 'debug_static_bot', 'mipsel'],
-    'android_gn_debug_static_bot_x64': ['android', 'chrome_with_codecs', 'gn', 'debug_static_bot', 'x64'],
-    'android_gn_debug_static_bot_x86': ['android', 'chrome_with_codecs', 'gn', 'debug_static_bot', 'x86'],
+    'android_gn_debug_bot': ['android', 'gn', 'debug_bot'],
+    'android_gn_debug_static_bot': ['android', 'gn', 'debug_static_bot'],
+    'android_gn_debug_static_bot_arm64': ['android', 'gn', 'debug_static_bot', 'arm64'],
+    'android_gn_debug_static_bot_mipsel': ['android', 'gn', 'debug_static_bot', 'mipsel'],
+    'android_gn_debug_static_bot_x64': ['android', 'gn', 'debug_static_bot', 'x64'],
+    'android_gn_debug_static_bot_x86': ['android', 'gn', 'debug_static_bot', 'x86'],
     'android_gn_release_bot': ['android', 'gn', 'release_bot'],
     'android_gn_release_trybot': ['android', 'gn', 'release_trybot'],
     'android_gyp_debug_static_bot': ['android', 'gyp', 'debug_static_bot'],
     'android_gyp_debug_static_bot_arm64': ['android', 'gyp', 'debug_static_bot', 'arm64'],
     'android_gyp_release_bot': ['android', 'gyp', 'release_bot'],
-    'android_gyp_release_bot_minimal_symbols': ['android', 'gyp', 'release_bot_minimal_symbols'],
     'cast_gn_release_bot': ['cast', 'gn', 'release_bot'],
     'cast_gn_release_trybot': ['cast', 'gn', 'release_trybot'],
     'chromeos_gn_debug_bot': ['chromeos', 'gn', 'debug_bot'],
@@ -34,6 +33,11 @@
     'dev_gyp_release': ['gyp', 'release', 'shared'],
     'embedded_gyp_debug_bot': ['embedded', 'gyp', 'debug_bot'],
 
+    # Explicitly use 'android_without_codecs' here since this bot is responsible
+    # for building publicly advertised non-Official Android builds which are not
+    # allowed to have proprietary codecs enabled.
+    'android_gyp_release_bot_minimal_symbols': ['android_without_codecs', 'gyp', 'release_bot_minimal_symbols'],

[Dirk Pranke, 2016/03/09 02:26:53]

I would actually change this name to
'android_without_codecs_gyp_release_bot_minimal_symbols' to be crystal-clear,
even if it is exceptionally verbose (the upside is that it at least follows the
normal config convention names). 

I would then make sure the comments for the 'android' mixin and the 'chromium'
waterfall are clear as to what they're doing, and omit the comment here.

[DaleCurtis, 2016/03/09 04:19:58]

Done.

+
     # This is the "deployment" config for the blimp builds. Currently
     # we want them to be debug, non-optimized builds (and we don't need any
     # chrome branding), so we don't use the "official" mixin.
@@ -66,7 +70,7 @@
     'gyp_official_goma_minimal_symbols_android_arm64': ['gyp', 'official', 'goma', 'minimal_symbols', 'android', 'arm64'],
     'gyp_official_goma_minimal_symbols_x64': ['gyp', 'official', 'goma', 'minimal_symbols', 'x64'],
     'gyp_official_goma_minimal_symbols_x86': ['gyp', 'official', 'goma', 'minimal_symbols', 'x86'],
-    'gyp_release_bot_android': ['gyp', 'release_bot', 'android'],
+    'gyp_release_bot_android': ['gyp', 'release_bot', 'android', 'chrome_with_codecs'],

[Dirk Pranke, 2016/03/09 02:26:53]

This change isn't needed, right?

[DaleCurtis, 2016/03/09 04:19:57]

Correct, stale change. Removed.

     'gyp_release_trybot': ['gyp', 'release_trybot'],
     'gyp_release_trybot_x64': ['gyp', 'release_trybot', 'x64'],
     'gn_release_libfuzzer_asan': ['gn', 'release', 'libfuzzer', 'asan', 'proprietary_codecs', 'pdf_xfa'],
@@ -88,7 +92,7 @@
     'noswarming_gyp_release_bot_mac_strip': ['noswarming', 'gyp', 'release_bot', 'mac_strip'],
     'noswarming_gyp_release_bot_x86': ['noswarming', 'gyp', 'release_bot', 'x86'],
 
-    'swarming_android_gn_release_bot_minimal_symbols': ['swarming', 'android', 'chrome_with_codecs', 'gn', 'release_bot_minimal_symbols'],
+    'swarming_android_gn_release_bot_minimal_symbols': ['swarming', 'android', 'gn', 'release_bot_minimal_symbols'],
     'swarming_asan_lsan_gyp_release_trybot': ['swarming', 'asan', 'lsan', 'release_trybot'],
     'swarming_msan_gyp_release_trybot': ['swarming', 'chromeos', 'msan', 'gyp', 'release_trybot'],
     'swarming_deterministic_gyp_release_bot': ['swarming', 'deterministic', 'gyp', 'release_bot'],
@@ -137,7 +141,6 @@
     'swarming_tsan_gyp_release_trybot': ['swarming', 'disable_nacl', 'tsan', 'gyp', 'release_trybot'],
 
     # Configurations that build with proprietary codecs enabled.
-    'android_gn_release_bot_chrome_with_codecs': ['android', 'gn', 'release_bot', 'chrome_with_codecs'],
     'gn_debug_bot_minimal_symbols_chrome_with_codecs': ['gn', 'debug_bot_minimal_symbols', 'chrome_with_codecs'],
     'gn_debug_static_bot_chrome_with_codecs': ['gn', 'debug_static_bot', 'chrome_with_codecs'],
     'gn_release_bot_chrome_with_codecs': ['gn', 'release_bot', 'chrome_with_codecs'],
@@ -181,6 +184,12 @@
     'android': {
       'gn_args': 'target_os="android"',
       'gyp_defines': 'OS=android',
+      'mixins': ['chrome_with_codecs'],

[Dirk Pranke, 2016/03/09 02:26:53]

Can we change this to:

  'android': {
    'mixins': ['android_without_codecs', 'chrome_with_codecs'],
  }

I think this is stylistically a bit clearer and cleaner.

Also, add a comment as to why we build w/ codecs by default on most bots but not
on the p/chromium bots ?

[DaleCurtis, 2016/03/09 04:19:57]

Good suggestion. Done.

+    },
+
+    'android_without_codecs': {
+      'gn_args': 'target_os="android"',
+      'gyp_defines': 'OS=android',
     },
 
     'archive_gpu_tests': {
@@ -482,6 +491,10 @@
     'chrome.continuous': {
       'precise64 trunk': 'gn_official',
     },
+    # Take care when changing any of these builders to ensure that you do not

[DaleCurtis, 2016/03/07 22:36:04]

I'm not a fan of this of enforcement by comment, so if there's a way to check
this at submit time through either a PRESUBMIT or some test please let me know
:)

[Dirk Pranke, 2016/03/09 02:26:53]

I agree that we should probably enforce this more strictly. the presubmit checks
run `mb validate`,
so we can change mb validate to check that no bot on the chromium waterfall
contains the chrome_with_codecs
defines.

[DaleCurtis, 2016/03/09 04:19:58]

Done. Added a unittest for that too.

+    # include a configuration with 'chrome_with_codecs' since these builders
+    # generated publicly advertised non-Official builds which are not allowed to
+    # have proprietary codecs enabled.
     'chromium': {
       'Win': 'noswarming_gyp_release_bot',
       'Mac': 'noswarming_gyp_release_bot_mac_strip',
@@ -672,7 +685,7 @@
       'Linux Release dEQP (NVIDIA)': 'none',
     },
     'chromium.webrtc.fyi': {
-      'Android GN': 'android_gn_release_bot_chrome_with_codecs',
+      'Android GN': 'android_gn_release_bot',
       'Android GN (dbg)': 'android_gn_debug_bot',
       'Linux Builder': 'gn_release_bot_chrome_with_codecs',
       'Mac GN': 'gn_release_bot_chrome_with_codecs',