sync compositor: Handle context loss

sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744
Committed: https://crrev.com/7c1bd415bfbed8d80249a4e25788fbe967c97699
Cr-Commit-Position: refs/heads/master@{#382978}

[boliu, 2016-03-22 21:24:43]

Description was changed from

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

NOT FOR COMMIT yet. Need to make sure lost resources are not returned to
new output surface.

BUG=592744
==========

to

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744
==========

[boliu, 2016-03-22 21:25:30]

boliu@chromium.org changed reviewers:
+ sievers@chromium.org

[boliu, 2016-03-22 21:25:31]

Part 2 for handling gpu thread context loss. No tests for this though..

[boliu, 2016-03-23 02:26:24]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[boliu, 2016-03-23 02:26:25]

actually I own everything here :)

+toby for regular review

[Tobias Sargeant, 2016-03-23 10:10:55]

lgtm

https://codereview.chromium.org/1773873002/diff/20001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_proxy.cc (right):

https://codereview.chromium.org/1773873002/diff/20001/content/renderer/androi...
content/renderer/android/synchronous_compositor_proxy.cc:77:
output_surface_->SetMemoryPolicy(bytes_limit_);
I guess previously we would never have called SetMemoryPolicy(0) initially on
the output surface (even if the browser sent that). Doesn't look like a problem
(in fact maybe this is more correct), but I thought I'd flag it.

[boliu, 2016-03-23 15:52:53]

https://codereview.chromium.org/1773873002/diff/20001/content/renderer/androi...
File content/renderer/android/synchronous_compositor_proxy.cc (right):

https://codereview.chromium.org/1773873002/diff/20001/content/renderer/androi...
content/renderer/android/synchronous_compositor_proxy.cc:77:
output_surface_->SetMemoryPolicy(bytes_limit_);
On 2016/03/23 10:10:55, Tobias Sargeant wrote:
> I guess previously we would never have called SetMemoryPolicy(0) initially on
> the output surface (even if the browser sent that). Doesn't look like a
problem
> (in fact maybe this is more correct), but I thought I'd flag it.

Same behavior either way.

[boliu, 2016-03-23 20:54:23]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-03-23 20:54:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773873002/20001

[commit-bot: I haz the power, 2016-03-23 23:50:17]

Description was changed from

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744
==========

to

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744
==========

[commit-bot: I haz the power, 2016-03-23 23:50:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 23:52:22]

Description was changed from

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744
==========

to

==========
sync compositor: Handle context loss

OutputSurface becomes a mutable part of SynchronousCompositorProxy.
Proxy needes to make sure access to OutputSurface are null checked. And
the Registry (ie SynchronousCompositorFilter) need to treat the
OutputSurface part as an optional part of Proxy init.

BUG=592744

Committed: https://crrev.com/7c1bd415bfbed8d80249a4e25788fbe967c97699
Cr-Commit-Position: refs/heads/master@{#382978}
==========

[commit-bot: I haz the power, 2016-03-23 23:52:23]

Patchset 2 (id:??) landed as
https://crrev.com/7c1bd415bfbed8d80249a4e25788fbe967c97699
Cr-Commit-Position: refs/heads/master@{#382978}