Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1773853003: Revert of Remove support for Alt-Svc/Alternate Protocol Probability (Closed)

Created:
4 years, 9 months ago by anthonyvd
Modified:
4 years, 9 months ago
Reviewers:
Bence, eroman, mef, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove support for Alt-Svc/Alternate Protocol Probability (patchset #7 id:120001 of https://codereview.chromium.org/1699653002/ ) Reason for revert: This appears to have broken the following bot: https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/43364 Original issue's description: > Remove support forAlt-Svc/Alternate Protocol Probability > > Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea > Cr-Commit-Position: refs/heads/master@{#379652} TBR=bnc@chromium.org,eroman@chromium.org,mef@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5b168c11bb7e574c6386f1857d58e5e4cad5e25a Cr-Commit-Position: refs/heads/master@{#379658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -174 lines) Patch
M chrome/browser/io_thread.cc View 3 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/resources/net_internals/quic_view.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 2 chunks +5 lines, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 3 chunks +30 lines, -0 lines 0 comments Download
M ios/crnet/CrNet.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ios/crnet/CrNet.mm View 3 chunks +7 lines, -0 lines 0 comments Download
M ios/crnet/crnet_environment.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 17 chunks +21 lines, -20 lines 0 comments Download
M net/http/http_server_properties.h View 6 chunks +17 lines, -3 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/http/http_server_properties_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 7 chunks +27 lines, -9 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 32 chunks +139 lines, -49 lines 0 comments Download
M net/http/http_server_properties_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 5 chunks +22 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 17 chunks +28 lines, -21 lines 0 comments Download
M net/http/http_stream_factory.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 9 chunks +222 lines, -56 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
anthonyvd
Created Revert of Remove support for Alt-Svc/Alternate Protocol Probability
4 years, 9 months ago (2016-03-07 22:02:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773853003/1
4 years, 9 months ago (2016-03-07 22:03:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 22:04:09 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 22:05:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b168c11bb7e574c6386f1857d58e5e4cad5e25a
Cr-Commit-Position: refs/heads/master@{#379658}

Powered by Google App Engine
This is Rietveld 408576698