third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp - Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

index 72614664832935970cfb9554d5a269ca83bca5e7..8ef9ca9c6a6db9bdaf5b39b0d6e61ffded826b4f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

@@ -16,7 +16,7 @@

namespace blink {

V8PerformanceObserverCallback::V8PerformanceObserverCallback(v8::Local<v8::Function> callback, v8::Local<v8::Object> owner, ScriptState* scriptState)

- : ActiveDOMCallback(scriptState->executionContext())

+ : ActiveDOMCallback(scriptState->getExecutionContext())

, m_callback(scriptState->isolate(), callback)

, m_scriptState(scriptState)

{

@@ -58,7 +58,7 @@ void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* en

v8::TryCatch exceptionCatcher(m_scriptState->isolate());

exceptionCatcher.SetVerbose(true);

- ScriptController::callFunction(m_scriptState->executionContext(), m_callback.newLocal(m_scriptState->isolate()), thisObject, 2, argv, m_scriptState->isolate());

+ ScriptController::callFunction(m_scriptState->getExecutionContext(), m_callback.newLocal(m_scriptState->isolate()), thisObject, 2, argv, m_scriptState->isolate());

}

void V8PerformanceObserverCallback::setWeakCallback(const v8::WeakCallbackInfo<V8PerformanceObserverCallback>& data)