third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h - Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

index 6b7c973c8b20cb4b37bd7ab55b18b8c699ea7953..4b6b7da60de5e4a0053d42d3f5041863b7a5472d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

@@ -17,7 +17,7 @@ namespace blink {

class ScriptStateForTesting : public ScriptState {

public:

static PassRefPtr<ScriptStateForTesting> create(v8::Local<v8::Context>, PassRefPtr<DOMWrapperWorld>);

- ExecutionContext* executionContext() const override;

+ ExecutionContext* getExecutionContext() const override;

void setExecutionContext(ExecutionContext*) override;

private:

ScriptStateForTesting(v8::Local<v8::Context>, PassRefPtr<DOMWrapperWorld>);

@@ -28,7 +28,7 @@ class V8TestingScope {

DISALLOW_NEW();

public:

explicit V8TestingScope(v8::Isolate*);

- ScriptState* scriptState() const;

+ ScriptState* getScriptState() const;

v8::Isolate* isolate() const;

v8::Local<v8::Context> context() const;

~V8TestingScope();