Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
index 53c60d24fed32d07d64fcaa1628199e95e0170fa..4da54ffc346d61244104e576d6356e1bc90a7d59 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
@@ -69,7 +69,7 @@ private:
ASSERT(m_resolveType == Fulfilled || m_resolveType == Rejected);
if (m_resolveType == Rejected) {
m_observer->reportError(value);
- value = ScriptPromise::reject(value.scriptState(), value).getScriptValue();
+ value = ScriptPromise::reject(value.getScriptState(), value).getScriptValue();
}
m_observer->decrementPendingActivity();
m_observer = nullptr;
@@ -93,7 +93,7 @@ void WaitUntilObserver::willDispatchEvent()
// waitUntil() isn't called, that means between willDispatchEvent() and
// didDispatchEvent().
if (m_type == NotificationClick)
- executionContext()->allowWindowInteraction();
+ getExecutionContext()->allowWindowInteraction();
incrementPendingActivity();
}
@@ -113,7 +113,7 @@ void WaitUntilObserver::waitUntil(ScriptState* scriptState, ScriptPromise script
return;
}
- if (!executionContext())
+ if (!getExecutionContext())
return;
// When handling a notificationclick event, we want to allow one window to
@@ -157,10 +157,10 @@ void WaitUntilObserver::incrementPendingActivity()
void WaitUntilObserver::decrementPendingActivity()
{
ASSERT(m_pendingActivity > 0);
- if (!executionContext() || (!m_hasError && --m_pendingActivity))
+ if (!getExecutionContext() || (!m_hasError && --m_pendingActivity))
return;
- ServiceWorkerGlobalScopeClient* client = ServiceWorkerGlobalScopeClient::from(executionContext());
+ ServiceWorkerGlobalScopeClient* client = ServiceWorkerGlobalScopeClient::from(getExecutionContext());
WebServiceWorkerEventResult result = m_hasError ? WebServiceWorkerEventResultRejected : WebServiceWorkerEventResultCompleted;
switch (m_type) {
case Activate:
@@ -192,9 +192,9 @@ void WaitUntilObserver::decrementPendingActivity()
void WaitUntilObserver::consumeWindowInteraction(Timer<WaitUntilObserver>*)
{
- if (!executionContext())
+ if (!getExecutionContext())
return;
- executionContext()->consumeWindowInteraction();
+ getExecutionContext()->consumeWindowInteraction();
}
DEFINE_TRACE(WaitUntilObserver)

Powered by Google App Engine
This is Rietveld 408576698