third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp - Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XSLTProcessor.cpp ('k') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

index 40ef1fcd118a8015b7f67b60e428f334877ee56b..9f79b05e40110b02fdf360f9829b6a420e7c9d8c 100644

--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -646,7 +646,7 @@ static bool shouldAllowExternalLoad(const KURL& url)

// content. If we had more context, we could potentially allow the parser to

// load a DTD. As things stand, we take the conservative route and allow

// same-origin requests only.

- if (!XMLDocumentParserScope::currentDocument->securityOrigin()->canRequest(url)) {

+ if (!XMLDocumentParserScope::currentDocument->getSecurityOrigin()->canRequest(url)) {

// FIXME: This is copy/pasted. We should probably build console logging into canRequest().

if (!url.isNull()) {

String message = "Unsafe attempt to load URL " + url.elidedString() +