third_party/WebKit/Source/modules/background_sync/SyncManager.cpp - Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp ('k') | third_party/WebKit/Source/modules/battery/BatteryManager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

index f58803e4e0a2d34c4ada9df9f649eb291108416c..a70b1bed5c98974c8a8027ea7febd2d8dfe64c40 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

+++ b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

@@ -44,8 +44,8 @@ ScriptPromise SyncManager::registerFunction(ScriptState* scriptState, ExecutionC

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Registration failed - no active Service Worker"));

- if (scriptState->executionContext()->isDocument()) {

- Document* document = toDocument(scriptState->executionContext());

+ if (scriptState->getExecutionContext()->isDocument()) {

+ Document* document = toDocument(scriptState->getExecutionContext());

if (!document->domWindow() || !document->frame())

return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "Document is detached from window."));

if (!document->frame()->isMainFrame())