Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index d46439c41679474bf235e7d39a86eb31c3b47489..24a27acae9753e48bc631e940cba4be362678a45 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -102,7 +102,7 @@ WebPermissionClient* Permissions::getClient(ExecutionContext* executionContext)
ScriptPromise Permissions::query(ScriptState* scriptState, const Dictionary& rawPermission)
{
- WebPermissionClient* client = getClient(scriptState->executionContext());
+ WebPermissionClient* client = getClient(scriptState->getExecutionContext());
if (!client)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't query permissions."));
@@ -118,13 +118,13 @@ ScriptPromise Permissions::query(ScriptState* scriptState, const Dictionary& raw
// meaningful value because most APIs are broken on file scheme and no
// permission prompt will be shown even if the returned permission will most
// likely be "prompt".
- client->queryPermission(type.get(), KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
+ client->queryPermission(type.get(), KURL(KURL(), scriptState->getExecutionContext()->getSecurityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
return promise;
}
ScriptPromise Permissions::request(ScriptState* scriptState, const Dictionary& rawPermission)
{
- WebPermissionClient* client = getClient(scriptState->executionContext());
+ WebPermissionClient* client = getClient(scriptState->getExecutionContext());
if (!client)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't request permissions."));
@@ -136,13 +136,13 @@ ScriptPromise Permissions::request(ScriptState* scriptState, const Dictionary& r
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
- client->requestPermission(type.get(), KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
+ client->requestPermission(type.get(), KURL(KURL(), scriptState->getExecutionContext()->getSecurityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
return promise;
}
ScriptPromise Permissions::revoke(ScriptState* scriptState, const Dictionary& rawPermission)
{
- WebPermissionClient* client = getClient(scriptState->executionContext());
+ WebPermissionClient* client = getClient(scriptState->getExecutionContext());
if (!client)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't revoke permissions."));
@@ -154,13 +154,13 @@ ScriptPromise Permissions::revoke(ScriptState* scriptState, const Dictionary& ra
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
- client->revokePermission(type.get(), KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
+ client->revokePermission(type.get(), KURL(KURL(), scriptState->getExecutionContext()->getSecurityOrigin()->toString()), new PermissionCallback(resolver, type.get()));
return promise;
}
ScriptPromise Permissions::requestAll(ScriptState* scriptState, const Vector<Dictionary>& rawPermissions)
{
- WebPermissionClient* client = getClient(scriptState->executionContext());
+ WebPermissionClient* client = getClient(scriptState->getExecutionContext());
if (!client)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't request permissions."));
@@ -191,7 +191,7 @@ ScriptPromise Permissions::requestAll(ScriptState* scriptState, const Vector<Dic
ScriptPromise promise = resolver->promise();
WebVector<WebPermissionType> internalWebPermissions = *internalPermissions;
- client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()),
+ client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState->getExecutionContext()->getSecurityOrigin()->toString()),
new PermissionsCallback(resolver, internalPermissions.release(), callerIndexToInternalIndex.release()));
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698