Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: extensions/renderer/script_context.h

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_ 5 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
6 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_ 6 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 std::string GetContextTypeDescription() const; 126 std::string GetContextTypeDescription() const;
127 127
128 // Returns a string description of the effective type of context this is. 128 // Returns a string description of the effective type of context this is.
129 std::string GetEffectiveContextTypeDescription() const; 129 std::string GetEffectiveContextTypeDescription() const;
130 130
131 v8::Isolate* isolate() const { return isolate_; } 131 v8::Isolate* isolate() const { return isolate_; }
132 132
133 // Get the URL of this context's web frame. 133 // Get the URL of this context's web frame.
134 // 134 //
135 // TODO(kalman): Remove this and replace with a GetOrigin() call which reads 135 // TODO(kalman): Remove this and replace with a GetOrigin() call which reads
136 // of WebDocument::securityOrigin(): 136 // of WebDocument::getSecurityOrigin():
137 // - The URL can change (e.g. pushState) but the origin cannot. Luckily it 137 // - The URL can change (e.g. pushState) but the origin cannot. Luckily it
138 // appears as though callers don't make security decisions based on the 138 // appears as though callers don't make security decisions based on the
139 // result of url() so it's not a problem... yet. 139 // result of url() so it's not a problem... yet.
140 // - Origin is the correct check to be making. 140 // - Origin is the correct check to be making.
141 // - It might let us remove the about:blank resolving? 141 // - It might let us remove the about:blank resolving?
142 const GURL& url() const { return url_; } 142 const GURL& url() const { return url_; }
143 143
144 // Sets the URL of this ScriptContext. Usually this will automatically be set 144 // Sets the URL of this ScriptContext. Usually this will automatically be set
145 // on construction, unless this isn't constructed with enough information to 145 // on construction, unless this isn't constructed with enough information to
146 // determine the URL (e.g. frame was null). 146 // determine the URL (e.g. frame was null).
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 scoped_ptr<Runner> runner_; 250 scoped_ptr<Runner> runner_;
251 251
252 base::ThreadChecker thread_checker_; 252 base::ThreadChecker thread_checker_;
253 253
254 DISALLOW_COPY_AND_ASSIGN(ScriptContext); 254 DISALLOW_COPY_AND_ASSIGN(ScriptContext);
255 }; 255 };
256 256
257 } // namespace extensions 257 } // namespace extensions
258 258
259 #endif // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_ 259 #endif // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
OLDNEW
« no previous file with comments | « extensions/renderer/programmatic_script_injector.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698