Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1773813004: Fix flag comparison in event_param_traits_unittest (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flag comparison in event_param_traits_unittest The result of flags() was converted to a boolean and then masked against an enum. VS 2015 complained that this makes no sense. The warning was: event_param_traits_unittest.cc(90): warning C4806: '&': unsafe operation: no value of type 'bool' promoted to type 'ui::MouseEventFlags' can equal the given constant Presumably the intent is to make sure the flags match. This can either be done by removing the !! or by wrapping the '&' expression in parentheses. This fix removes the !!. Bug was introduced in crrev.com/1695783002, but only triggers on VS 2015 gn builds. BUG=440500, 582658 Committed: https://crrev.com/48843ccd23afd0147f1484c57bd3fab73e482427 Cr-Commit-Position: refs/heads/master@{#380008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/mus/common/event_param_traits_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
brucedawson
PTAL
4 years, 9 months ago (2016-03-08 21:44:36 UTC) #4
sky
LGTM
4 years, 9 months ago (2016-03-08 22:56:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773813004/1
4 years, 9 months ago (2016-03-09 00:05:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 01:09:10 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:10:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48843ccd23afd0147f1484c57bd3fab73e482427
Cr-Commit-Position: refs/heads/master@{#380008}

Powered by Google App Engine
This is Rietveld 408576698