Validation of `@mustCallSuper` overrides.

Validation of `@mustCallSuper` overrides.

Carried over and refined from https://codereview.chromium.org/1767843002/.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/4528052e98d1a76c23c8429912c037656dd957fa

[pquitslund, 2016-03-07 20:31:22]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-03-07 21:07:09]

LGTM

https://codereview.chromium.org/1773803002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1773803002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:4430: return;
I think this 'return' wants to be in the outer 'if' statement. Basically, we can
stop as soon as we've found a method annotated with @mustCallSuper, whether
there was a problem or not. Might be more clear if there were a utility method

  bool _mustCallSuper(MethodDeclaration node)

that looks up the override chain.

[pquitslund, 2016-03-07 21:29:39]

Thanks!

https://codereview.chromium.org/1773803002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1773803002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:4430: return;
On 2016/03/07 21:07:09, Brian Wilkerson wrote:
> I think this 'return' wants to be in the outer 'if' statement. Basically, we
can
> stop as soon as we've found a method annotated with @mustCallSuper, whether
> there was a problem or not. Might be more clear if there were a utility method
> 
>   bool _mustCallSuper(MethodDeclaration node)
> 
> that looks up the override chain.

Good catch and good idea.

Updating.

[pquitslund, 2016-03-07 21:37:40]

Description was changed from

==========
Validation of `@mustCallSuper` overrides.

Carried over and refined from https://codereview.chromium.org/1767843002/.

BUG=
==========

to

==========
Validation of `@mustCallSuper` overrides.

Carried over and refined from https://codereview.chromium.org/1767843002/.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4528052e98d1a76c23c8429912c037656dd957fa
==========

[pquitslund, 2016-03-07 21:37:41]

Committed patchset #1 (id:1) manually as
4528052e98d1a76c23c8429912c037656dd957fa (presubmit successful).