xfa/src/fxbarcode/oned/BC_OneDReader.h - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OneDReader.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OneDReader.h

diff --git a/xfa/src/fxbarcode/oned/BC_OneDReader.h b/xfa/src/fxbarcode/oned/BC_OneDReader.h

index 27a1a3d7eea7286b7955cc2394a9e7d3663800e5..bcd7cbc8b526f3242b2c48f70eb1fbda3ce3f541 100644

--- a/xfa/src/fxbarcode/oned/BC_OneDReader.h

+++ b/xfa/src/fxbarcode/oned/BC_OneDReader.h

@@ -31,8 +31,9 @@ class CBC_OneDReader : public CBC_Reader {

CFX_ByteString DeDecode(CBC_BinaryBitmap* image, int32_t hints, int32_t& e);

protected:

- const static int32_t INTEGER_MATH_SHIFT;

- const static int32_t PATTERN_MATCH_RESULT_SCALE_FACTOR;

+ static const int32_t INTEGER_MATH_SHIFT = 8;

+ static const int32_t PATTERN_MATCH_RESULT_SCALE_FACTOR = 1 << 8;

void RecordPattern(CBC_CommonBitArray* row,

int32_t start,

CFX_Int32Array* counters,