Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: core/src/fxcrt/fx_basic_bstring.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.cpp ('k') | core/src/fxcrt/fx_basic_gcc.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/fx_basic_bstring.cpp
diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp
index 8b4442e82339fb91ce3e176ef8a39a9b3f9038a3..5d38d57757e4d59d0be9ec4a20a95c2634ec4f55 100644
--- a/core/src/fxcrt/fx_basic_bstring.cpp
+++ b/core/src/fxcrt/fx_basic_bstring.cpp
@@ -4,7 +4,8 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#include <stddef.h> // For offsetof().
+#include <stddef.h>
+
#include <cctype>
#include "core/include/fxcrt/fx_basic.h"
@@ -22,15 +23,15 @@ static int _Buffer_itoa(char* buf, int i, FX_DWORD flags) {
u = -i;
}
int base = 10;
- const FX_CHAR* string = "0123456789abcdef";
+ const FX_CHAR* str = "0123456789abcdef";
if (flags & FXFORMAT_HEX) {
base = 16;
if (flags & FXFORMAT_CAPITAL) {
- string = "0123456789ABCDEF";
+ str = "0123456789ABCDEF";
}
}
while (u != 0) {
- buf1[buf_pos--] = string[u % base];
+ buf1[buf_pos--] = str[u % base];
u = u / base;
}
if ((flags & FXFORMAT_SIGNED) && i < 0) {
@@ -202,19 +203,18 @@ const CFX_ByteString& CFX_ByteString::operator+=(char ch) {
ConcatInPlace(1, &ch);
return *this;
}
-const CFX_ByteString& CFX_ByteString::operator+=(const CFX_ByteString& string) {
- if (!string.m_pData) {
+const CFX_ByteString& CFX_ByteString::operator+=(const CFX_ByteString& str) {
+ if (!str.m_pData) {
return *this;
}
- ConcatInPlace(string.m_pData->m_nDataLength, string.m_pData->m_String);
+ ConcatInPlace(str.m_pData->m_nDataLength, str.m_pData->m_String);
return *this;
}
-const CFX_ByteString& CFX_ByteString::operator+=(
- const CFX_ByteStringC& string) {
- if (string.IsEmpty()) {
+const CFX_ByteString& CFX_ByteString::operator+=(const CFX_ByteStringC& str) {
+ if (str.IsEmpty()) {
return *this;
}
- ConcatInPlace(string.GetLength(), string.GetCStr());
+ ConcatInPlace(str.GetLength(), str.GetCStr());
return *this;
}
bool CFX_ByteString::Equal(const char* ptr) const {
« no previous file with comments | « core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.cpp ('k') | core/src/fxcrt/fx_basic_gcc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698