xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h

diff --git a/xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h b/xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h

index ccd6a84a0d28bfafd02de834f68a18e980f6893e..52b90a24c83ae24384bef2336a8391f67e87813f 100644

--- a/xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h

+++ b/xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h

@@ -38,8 +38,8 @@ class CBC_WhiteRectangleDetector {

int32_t b,

int32_t fixed,

FX_BOOL horizontal);

- const static int32_t INIT_SIZE;

- const static int32_t CORR;

+ static const int32_t INIT_SIZE;

Tom Sepez 2016/03/08 19:27:05 If possible, these really deserve an initializer h

dsinclair 2016/03/08 21:08:02 Done.

+ static const int32_t CORR;

CBC_CommonBitMatrix* m_image;

int32_t m_height;