Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
index aaeb4d6c3f03cb3c908c93f2b814e61a82d87eb2..04c3bc777d7e7718ad763634e035ac2c9dc503c8 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
@@ -633,7 +633,7 @@ void CPDFXFA_Document::ExportData(IXFA_Doc* hDoc,
content.GetLength());
CFX_WideStringC data(L"data");
if (pXFADocHander->SavePackage(m_pXFADocView->GetDoc(), data, &fileWrite)) {
- // TODO: Maybe report error.
+ // Ignoring error.
}
} else if (fileType == FXFA_SAVEAS_XDP) {
if (m_pPDFDoc == NULL)
@@ -693,12 +693,11 @@ void CPDFXFA_Document::ExportData(IXFA_Doc* hDoc,
}
}
if (!fileWrite.Flush()) {
- // TODO: Report error.
+ // Ignoring flush error.
}
}
void CPDFXFA_Document::ImportData(IXFA_Doc* hDoc,
const CFX_WideStringC& wsFilePath) {
- // TODO ...
}
void CPDFXFA_Document::GotoURL(IXFA_Doc* hDoc,
@@ -1000,7 +999,6 @@ FX_BOOL CPDFXFA_Document::_ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
pDocHandler->SavePackage(m_pXFADoc, ws, &fileStream);
} else {
// PDF,creator.
- // TODO:
}
}
}
@@ -1191,7 +1189,7 @@ FX_BOOL CPDFXFA_Document::_SubmitData(IXFA_Doc* hDoc, CXFA_Submit submit) {
bsSubject.ReleaseBuffer();
bsMsg.ReleaseBuffer();
} else {
- // http¡¢ftp
+ // http or ftp
Tom Sepez 2016/03/08 19:27:05 Nit: HTTP or FTP since they are initials.
dsinclair 2016/03/08 21:08:02 Done.
CFX_WideString ws;
CFX_ByteString bs = csURL.UTF16LE_Encode();
int len = bs.GetLength() / sizeof(unsigned short);

Powered by Google App Engine
This is Rietveld 408576698