core/src/fxcrt/fx_basic_bstring.cpp - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_bstring.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_bstring.cpp

diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp

index 8b4442e82339fb91ce3e176ef8a39a9b3f9038a3..f710a4fa55d25caad4e6b889882a356a455e84df 100644

--- a/core/src/fxcrt/fx_basic_bstring.cpp

+++ b/core/src/fxcrt/fx_basic_bstring.cpp

@@ -4,8 +4,10 @@

-#include <stddef.h> // For offsetof().

+#include <stddef.h>

#include <cctype>

+#include <string>

Tom Sepez 2016/03/08 19:27:05 There aren't any std::strings in the core PDFium c

dsinclair 2016/03/08 21:08:02 Done.

#include "core/include/fxcrt/fx_basic.h"

#include "third_party/base/numerics/safe_math.h"