Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 502aaac9b32a4b8ede1e304581a6ba4c75ad5c85..47f3ad15d44d0521100c4502de2d2f3b2fe0a0a0 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -9,25 +9,30 @@ for more details about the presubmit API built into depot_tools. |
| """ |
| LINT_FILTERS = [ |
| + # Rvalue ref checks are unreliable. |
| '-build/c++11', |
| + # Need to fix header names not matching cpp names. |
| '-build/include', |
| + # Need to fix header names not matching cpp names. |
| '-build/include_order', |
| - '-build/include_what_you_use', |
| - '-build/namespaces', |
| - '-build/storage_class', |
| + # Too many to fix at the moment. |
| '-readability/casting', |
| + # Need to refactor large methods to fix. |
| '-readability/fn_size', |
| - '-readability/todo', |
| - '-readability/utf8', |
| - '-runtime/arrays', |
| + # Need to fix pdfium:426 |
|
Tom Sepez
2016/03/08 19:27:04
I thought you fixed this. Does this go away when
dsinclair
2016/03/08 21:08:01
Done.
|
| '-runtime/casting', |
| + # Need to fix errors when making methods explicit. |
| '-runtime/explicit', |
| + # Lots of usage to fix first. |
| '-runtime/int', |
| + # Need to fix two snprintf TODOs |
| '-runtime/printf', |
| + # Lots of non const references need to be fixed |
|
Tom Sepez
2016/03/08 19:27:04
nit: A truly picky person would say "non-const" bu
dsinclair
2016/03/08 21:08:01
Done.
|
| '-runtime/references', |
| + # Need to fix thread-unsafe methods to enable this. |
|
Tom Sepez
2016/03/08 19:27:04
Actually, we can't support threads, so we don't ca
dsinclair
2016/03/08 21:08:01
Done.
|
| '-runtime/threadsafe_fn', |
| + # Figure out how to deal with #defines that git cl format creates. |
| '-whitespace/indent', |
| - '-whitespace/line_length', |
| ] |
| def CheckChangeOnUpload(input_api, output_api): |