core/src/fpdfdoc/doc_action.cpp - Issue 1773733002: Review and cleanup lint warnings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fpdfdoc/doc_action.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp ('K') | « core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp ('k') | core/src/fpdfdoc/doc_form.cpp » ('j') | core/src/fpdfdoc/doc_form.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include <vector>

	8

7 #include "core/include/fpdfdoc/fpdf_doc.h"	9 #include "core/include/fpdfdoc/fpdf_doc.h"

8	10

9 CPDF_Dest CPDF_Action::GetDest(CPDF_Document* pDoc) const {	11 CPDF_Dest CPDF_Action::GetDest(CPDF_Document* pDoc) const {

10 if (!m_pDict) {	12 if (!m_pDict) {

11 return CPDF_Dest();	13 return CPDF_Dest();

12 }	14 }

13 CFX_ByteString type = m_pDict->GetStringBy("S");	15 CFX_ByteString type = m_pDict->GetStringBy("S");

14 if (type != "GoTo" && type != "GoToR") {	16 if (type != "GoTo" && type != "GoToR") {

15 return CPDF_Dest();	17 return CPDF_Dest();

16 }	18 }

(...skipping 265 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
282 if (!ToDictionary(pAction)) {	284 if (!ToDictionary(pAction)) {

283 return CPDF_Action();	285 return CPDF_Action();

284 }	286 }

285 return CPDF_Action(pAction->GetDict());	287 return CPDF_Action(pAction->GetDict());

286 }	288 }

287 int CPDF_DocJSActions::FindJSAction(const CFX_ByteString& csName) const {	289 int CPDF_DocJSActions::FindJSAction(const CFX_ByteString& csName) const {

288 ASSERT(m_pDocument);	290 ASSERT(m_pDocument);

289 CPDF_NameTree name_tree(m_pDocument, "JavaScript");	291 CPDF_NameTree name_tree(m_pDocument, "JavaScript");

290 return name_tree.GetIndex(csName);	292 return name_tree.GetIndex(csName);

291 }	293 }

OLD	NEW