Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 177373010: [Privet FS] Allow files to be able to be copied in to the privet filesystem (Closed)

Created:
6 years, 9 months ago by Noam Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Allow files to be able to be copied in to the privet filesystem This CL adds the ability to copy files in to the privet filesystem from outside the privet filesystem. It does not address ordering/safety issues, which are still somewhat minimal when copying whole files in. These will be addressed later. BUG=332182

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -7 lines) Patch
M chrome/browser/local_discovery/privet_http.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 6 chunks +31 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_async_util.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_operations.h View 2 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/storage/privet_filesystem_operations.cc View 1 2 chunks +79 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Noam Samuel
6 years, 9 months ago (2014-03-04 19:34:22 UTC) #1
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/177373010/diff/1/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc File chrome/browser/local_discovery/storage/privet_filesystem_operations.cc (right): https://codereview.chromium.org/177373010/diff/1/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc#newcode864 chrome/browser/local_discovery/storage/privet_filesystem_operations.cc:864: overwrite_operation_->Start(); start twice?
6 years, 9 months ago (2014-03-04 19:39:00 UTC) #2
Noam Samuel
https://codereview.chromium.org/177373010/diff/1/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc File chrome/browser/local_discovery/storage/privet_filesystem_operations.cc (right): https://codereview.chromium.org/177373010/diff/1/chrome/browser/local_discovery/storage/privet_filesystem_operations.cc#newcode864 chrome/browser/local_discovery/storage/privet_filesystem_operations.cc:864: overwrite_operation_->Start(); On 2014/03/04 19:39:00, Vitaly Buka wrote: > start ...
6 years, 9 months ago (2014-03-04 20:10:30 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 9 months ago (2014-03-04 20:12:23 UTC) #4
Noam Samuel
6 years, 8 months ago (2014-04-02 18:29:45 UTC) #5
Review #4

Powered by Google App Engine
This is Rietveld 408576698