Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 177373009: Compatibility fix for arm64 on iOS (Closed)

Created:
6 years, 9 months ago by sdefresne
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ocmock.0
Visibility:
Public.

Description

Compatibility fix for arm64 on iOS Manually patches in 77400c22b5bafd8aaaa75f90a1d997838204577a from upstream. Description: Also on arm64, BOOL seems to be encoded as "bool" (the 'B' objcType, or _C_BOOL) rather than the historical 'c', but NSValue can still use 'c', so we need to have those compare as equal. BUG=314720 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255187

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update description in README.chromium #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M third_party/ocmock/OCMock/NSInvocation+OCMAdditions.m View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.m View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/ocmock/README.chromium View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sdefresne
Please take a look.
6 years, 9 months ago (2014-03-04 16:58:15 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/177373009/diff/1/third_party/ocmock/README.chromium File third_party/ocmock/README.chromium (right): https://codereview.chromium.org/177373009/diff/1/third_party/ocmock/README.chromium#newcode31 third_party/ocmock/README.chromium:31: compatibility for arm64 iOS targets. Say a little ...
6 years, 9 months ago (2014-03-04 17:06:00 UTC) #2
sdefresne
Thank you for the quick review. https://codereview.chromium.org/177373009/diff/1/third_party/ocmock/README.chromium File third_party/ocmock/README.chromium (right): https://codereview.chromium.org/177373009/diff/1/third_party/ocmock/README.chromium#newcode31 third_party/ocmock/README.chromium:31: compatibility for arm64 ...
6 years, 9 months ago (2014-03-04 17:16:24 UTC) #3
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-04 17:43:02 UTC) #4
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 9 months ago (2014-03-05 13:24:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/177373009/40001
6 years, 9 months ago (2014-03-05 13:24:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 13:44:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53598
6 years, 9 months ago (2014-03-05 13:44:10 UTC) #8
sdefresne
On 2014/03/05 13:44:10, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-05 16:13:13 UTC) #9
Robert Sesek
lgtm
6 years, 9 months ago (2014-03-05 17:05:26 UTC) #10
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 9 months ago (2014-03-05 17:06:47 UTC) #11
sdefresne
On 2014/03/05 17:05:26, rsesek wrote: > lgtm Thank you!
6 years, 9 months ago (2014-03-05 17:06:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/177373009/40001
6 years, 9 months ago (2014-03-05 17:07:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/177373009/40001
6 years, 9 months ago (2014-03-05 23:55:56 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:07:07 UTC) #15
Message was sent while issue was closed.
Change committed as 255187

Powered by Google App Engine
This is Rietveld 408576698