Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/x64/builtins-x64.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Oversight Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/transitions-inl.h ('k') | src/x87/builtins-x87.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/builtins-x64.cc
diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc
index 84e07ea04750f3fcceb9f98c316877834937aa00..102c7552e71f027dcf4df2f1d129e24060e9e41c 100644
--- a/src/x64/builtins-x64.cc
+++ b/src/x64/builtins-x64.cc
@@ -1809,40 +1809,6 @@ void Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
{ // Too few parameters: Actual < expected.
__ bind(&too_few);
- // If the function is strong we need to throw an error.
- Label no_strong_error;
- __ movp(kScratchRegister,
- FieldOperand(rdi, JSFunction::kSharedFunctionInfoOffset));
- __ testb(FieldOperand(kScratchRegister,
- SharedFunctionInfo::kStrongModeByteOffset),
- Immediate(1 << SharedFunctionInfo::kStrongModeBitWithinByte));
- __ j(equal, &no_strong_error, Label::kNear);
-
- // What we really care about is the required number of arguments.
-
- if (kPointerSize == kInt32Size) {
- __ movp(
- kScratchRegister,
- FieldOperand(kScratchRegister, SharedFunctionInfo::kLengthOffset));
- __ SmiToInteger32(kScratchRegister, kScratchRegister);
- } else {
- // See comment near kLengthOffset in src/objects.h
- __ movsxlq(
- kScratchRegister,
- FieldOperand(kScratchRegister, SharedFunctionInfo::kLengthOffset));
- __ shrq(kScratchRegister, Immediate(1));
- }
-
- __ cmpp(rax, kScratchRegister);
- __ j(greater_equal, &no_strong_error, Label::kNear);
-
- {
- FrameScope frame(masm, StackFrame::MANUAL);
- EnterArgumentsAdaptorFrame(masm);
- __ CallRuntime(Runtime::kThrowStrongModeTooFewArguments);
- }
-
- __ bind(&no_strong_error);
EnterArgumentsAdaptorFrame(masm);
ArgumentsAdaptorStackCheck(masm, &stack_overflow);
« no previous file with comments | « src/transitions-inl.h ('k') | src/x87/builtins-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698