Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Oversight Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/d8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 6ee20a8f8e7db95abd17426ca0a36f59f37266fb..b869f27184c4f3a9d002d888349bfb23beb1d564 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -6551,13 +6551,7 @@ HValue* HOptimizedGraphBuilder::BuildMonomorphicAccess(
if (!info->IsFound()) {
DCHECK(info->IsLoad());
- if (is_strong(function_language_mode())) {
- return New<HCallRuntime>(
- Runtime::FunctionForId(Runtime::kThrowStrongModeImplicitConversion),
- 0);
- } else {
- return graph()->GetConstantUndefined();
- }
+ return graph()->GetConstantUndefined();
}
if (info->IsData()) {
@@ -8459,15 +8453,6 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
}
}
- // In strong mode it is an error to call a function with too few arguments.
- // In that case do not inline because then the arity check would be skipped.
- if (is_strong(function->language_mode()) &&
- arguments_count < function->parameter_count()) {
- TraceInline(target, caller,
- "too few arguments passed to a strong function");
- return false;
- }
-
// Generate the deoptimization data for the unoptimized version of
// the target function if we don't already have it.
if (!Compiler::EnsureDeoptimizationSupport(&target_info)) {
@@ -10644,7 +10629,7 @@ HInstruction* HOptimizedGraphBuilder::BuildIncrement(
rep = Representation::Smi();
}
- if (returns_original_input && !is_strong(function_language_mode())) {
+ if (returns_original_input) {
// We need an explicit HValue representing ToNumber(input). The
// actual HChange instruction we need is (sometimes) added in a later
// phase, so it is not available now to be used as an input to HAdd and
@@ -10669,11 +10654,7 @@ HInstruction* HOptimizedGraphBuilder::BuildIncrement(
add->set_observed_input_representation(1, rep);
add->set_observed_input_representation(2, Representation::Smi());
}
- if (!is_strong(function_language_mode())) {
- instr->ClearAllSideEffects();
- } else {
- Add<HSimulate>(expr->ToNumberId(), REMOVABLE_SIMULATE);
- }
+ instr->ClearAllSideEffects();
instr->SetFlag(HInstruction::kCannotBeTagged);
return instr;
}
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/d8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698