Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: src/s390/builtins-s390.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/s390/builtins-s390.cc
diff --git a/src/s390/builtins-s390.cc b/src/s390/builtins-s390.cc
index 35aaeb95d286b55fe8c861a24eab40f44e29b16c..179dfd8b87068b23fbaedb058e958054b4898c9d 100644
--- a/src/s390/builtins-s390.cc
+++ b/src/s390/builtins-s390.cc
@@ -2496,32 +2496,6 @@ void Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
{ // Too few parameters: Actual < expected
__ bind(&too_few);
- // If the function is strong we need to throw an error.
- Label no_strong_error;
- __ LoadP(r6, FieldMemOperand(r3, JSFunction::kSharedFunctionInfoOffset));
- __ LoadlW(r7,
- FieldMemOperand(r6, SharedFunctionInfo::kCompilerHintsOffset));
- __ TestBit(r7, SharedFunctionInfo::kStrongModeBit, r0);
- __ beq(&no_strong_error);
-
- // What we really care about is the required number of arguments.
- __ LoadlW(r6, FieldMemOperand(r6, SharedFunctionInfo::kLengthOffset));
-#if V8_TARGET_ARCH_S390X
- // See commment near kLenghtOffset in src/objects.h
- __ ShiftRightArith(r6, r6, Operand(kSmiTagSize));
-#else
- __ SmiUntag(r6);
-#endif
- __ CmpP(r2, r6);
- __ bge(&no_strong_error);
-
- {
- FrameScope frame(masm, StackFrame::MANUAL);
- EnterArgumentsAdaptorFrame(masm);
- __ CallRuntime(Runtime::kThrowStrongModeTooFewArguments);
- }
-
- __ bind(&no_strong_error);
EnterArgumentsAdaptorFrame(masm);
ArgumentAdaptorStackCheck(masm, &stack_overflow);

Powered by Google App Engine
This is Rietveld 408576698