Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: src/objects.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index cb812642842c87aae945048874cab7cc827ee889..680f8e50b2d68d1ab1224fed731210fe1c8080c4 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -9498,9 +9498,8 @@ Handle<Map> Map::AsLanguageMode(Handle<Map> initial_map,
LanguageMode language_mode, FunctionKind kind) {
DCHECK_EQ(JS_FUNCTION_TYPE, initial_map->instance_type());
// Initial map for sloppy mode function is stored in the function
- // constructor. Initial maps for strict and strong modes are cached as
- // special transitions using |strict_function_transition_symbol| and
- // |strong_function_transition_symbol| respectively as a key.
+ // constructor. Initial maps for strict mode are cached as special transitions
+ // using |strict_function_transition_symbol| as a key.
if (language_mode == SLOPPY) return initial_map;
Isolate* isolate = initial_map->GetIsolate();
Factory* factory = isolate->factory();
@@ -9515,9 +9514,6 @@ Handle<Map> Map::AsLanguageMode(Handle<Map> initial_map,
case STRICT:
transition_symbol = factory->strict_function_transition_symbol();
break;
- case STRONG:
- transition_symbol = factory->strong_function_transition_symbol();
- break;
default:
UNREACHABLE();
break;
@@ -16714,7 +16710,6 @@ class StringSharedKey : public HashTableKey {
hash ^= String::cast(script->source())->Hash();
STATIC_ASSERT(LANGUAGE_END == 3);
if (is_strict(language_mode)) hash ^= 0x8000;
- if (is_strong(language_mode)) hash ^= 0x10000;
hash += scope_position;
}
return hash;

Powered by Google App Engine
This is Rietveld 408576698