Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/compiler.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index a31e6a71fbbff3b1d00de103af1eb534c0381d28..5f754fc30630f0718145f9c0191f67c5c5825dd9 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1558,12 +1558,7 @@ Handle<SharedFunctionInfo> Compiler::CompileScript(
isolate->counters()->total_load_size()->Increment(source_length);
isolate->counters()->total_compile_size()->Increment(source_length);
- // TODO(rossberg): The natives do not yet obey strong mode rules
- // (for example, some macros use '==').
- bool use_strong = FLAG_use_strong && !isolate->bootstrapper()->IsActive();
- LanguageMode language_mode =
- construct_language_mode(FLAG_use_strict, use_strong);
-
+ LanguageMode language_mode = construct_language_mode(FLAG_use_strict);
CompilationCache* compilation_cache = isolate->compilation_cache();
// Do a lookup in the compilation cache but not for extensions.
@@ -1676,8 +1671,7 @@ Handle<SharedFunctionInfo> Compiler::CompileStreamedScript(
isolate->counters()->total_load_size()->Increment(source_length);
isolate->counters()->total_compile_size()->Increment(source_length);
- LanguageMode language_mode =
- construct_language_mode(FLAG_use_strict, FLAG_use_strong);
+ LanguageMode language_mode = construct_language_mode(FLAG_use_strict);
parse_info->set_language_mode(
static_cast<LanguageMode>(parse_info->language_mode() | language_mode));
« no previous file with comments | « src/bootstrapper.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | src/globals.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698