Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 1773653002: [strong] Remove all remainders of strong mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | src/globals.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 2455 matching lines...) Expand 10 before | Expand all | Expand 10 after
2466 __ push(ip); 2466 __ push(ip);
2467 __ cmp(r0, r4); // Compare before moving to next argument. 2467 __ cmp(r0, r4); // Compare before moving to next argument.
2468 __ sub(r0, r0, Operand(kPointerSize)); 2468 __ sub(r0, r0, Operand(kPointerSize));
2469 __ b(ne, &copy); 2469 __ b(ne, &copy);
2470 2470
2471 __ b(&invoke); 2471 __ b(&invoke);
2472 } 2472 }
2473 2473
2474 { // Too few parameters: Actual < expected 2474 { // Too few parameters: Actual < expected
2475 __ bind(&too_few); 2475 __ bind(&too_few);
2476
2477 // If the function is strong we need to throw an error.
2478 Label no_strong_error;
2479 __ ldr(r4, FieldMemOperand(r1, JSFunction::kSharedFunctionInfoOffset));
2480 __ ldr(r5, FieldMemOperand(r4, SharedFunctionInfo::kCompilerHintsOffset));
2481 __ tst(r5, Operand(1 << (SharedFunctionInfo::kStrongModeFunction +
2482 kSmiTagSize)));
2483 __ b(eq, &no_strong_error);
2484
2485 // What we really care about is the required number of arguments.
2486 __ ldr(r4, FieldMemOperand(r4, SharedFunctionInfo::kLengthOffset));
2487 __ cmp(r0, Operand::SmiUntag(r4));
2488 __ b(ge, &no_strong_error);
2489
2490 {
2491 FrameScope frame(masm, StackFrame::MANUAL);
2492 EnterArgumentsAdaptorFrame(masm);
2493 __ CallRuntime(Runtime::kThrowStrongModeTooFewArguments);
2494 }
2495
2496 __ bind(&no_strong_error);
2497 EnterArgumentsAdaptorFrame(masm); 2476 EnterArgumentsAdaptorFrame(masm);
2498 ArgumentAdaptorStackCheck(masm, &stack_overflow); 2477 ArgumentAdaptorStackCheck(masm, &stack_overflow);
2499 2478
2500 // Calculate copy start address into r0 and copy end address is fp. 2479 // Calculate copy start address into r0 and copy end address is fp.
2501 // r0: actual number of arguments as a smi 2480 // r0: actual number of arguments as a smi
2502 // r1: function 2481 // r1: function
2503 // r2: expected number of arguments 2482 // r2: expected number of arguments
2504 // r3: new target (passed through to callee) 2483 // r3: new target (passed through to callee)
2505 __ add(r0, fp, Operand::PointerOffsetFromSmiKey(r0)); 2484 __ add(r0, fp, Operand::PointerOffsetFromSmiKey(r0));
2506 2485
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
2567 } 2546 }
2568 } 2547 }
2569 2548
2570 2549
2571 #undef __ 2550 #undef __
2572 2551
2573 } // namespace internal 2552 } // namespace internal
2574 } // namespace v8 2553 } // namespace v8
2575 2554
2576 #endif // V8_TARGET_ARCH_ARM 2555 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | src/globals.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698