Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 1773633002: Add fast path smi comparison operators. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: other platforms Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 3110 matching lines...) Expand 10 before | Expand all | Expand 10 after
3121 break; 3121 break;
3122 case Token::kBIT_OR: 3122 case Token::kBIT_OR:
3123 // Operation part of combined smi check. 3123 // Operation part of combined smi check.
3124 break; 3124 break;
3125 case Token::kBIT_AND: 3125 case Token::kBIT_AND:
3126 __ and_(result, left, Operand(right)); 3126 __ and_(result, left, Operand(right));
3127 break; 3127 break;
3128 case Token::kBIT_XOR: 3128 case Token::kBIT_XOR:
3129 __ eor(result, left, Operand(right)); 3129 __ eor(result, left, Operand(right));
3130 break; 3130 break;
3131 case Token::kEQ:
3132 case Token::kLT:
3133 case Token::kLTE:
3134 case Token::kGT:
3135 case Token::kGTE: {
3136 Label true_label, false_label, done;
3137 BranchLabels labels = { &true_label, &false_label, &false_label };
3138 Condition true_condition =
3139 EmitSmiComparisonOp(compiler, locs(), op_kind());
3140 EmitBranchOnCondition(compiler, true_condition, labels);
3141 __ Bind(&false_label);
3142 __ LoadObject(result, Bool::False());
3143 __ b(&done);
3144 __ Bind(&true_label);
3145 __ LoadObject(result, Bool::True());
3146 __ Bind(&done);
3147 break;
3148 }
3131 default: 3149 default:
3132 UNIMPLEMENTED(); 3150 UNIMPLEMENTED();
3133 } 3151 }
3134 __ Bind(slow_path->exit_label()); 3152 __ Bind(slow_path->exit_label());
3135 } 3153 }
3136 3154
3137 3155
3138 LocationSummary* BinarySmiOpInstr::MakeLocationSummary(Zone* zone, 3156 LocationSummary* BinarySmiOpInstr::MakeLocationSummary(Zone* zone,
3139 bool opt) const { 3157 bool opt) const {
3140 const intptr_t kNumInputs = 2; 3158 const intptr_t kNumInputs = 2;
(...skipping 3768 matching lines...) Expand 10 before | Expand all | Expand 10 after
6909 1, 6927 1,
6910 locs()); 6928 locs());
6911 __ Drop(1); 6929 __ Drop(1);
6912 __ Pop(result); 6930 __ Pop(result);
6913 } 6931 }
6914 6932
6915 6933
6916 } // namespace dart 6934 } // namespace dart
6917 6935
6918 #endif // defined TARGET_ARCH_ARM 6936 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698