Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1773633002: Add fast path smi comparison operators. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add fast path smi comparison operators. Only rudimentary support for now, gives around 15% speedup on richards, precompiled. Branch-merging is not yet supported in this CL. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/21488156739fc99404735624ae70ee9f37c27427

Patch Set 1 #

Patch Set 2 : other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -4 lines) Patch
M runtime/vm/aot_optimizer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 5 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 9 months ago (2016-03-07 16:38:57 UTC) #3
Vyacheslav Egorov (Google)
lgtm
4 years, 9 months ago (2016-03-07 16:41:44 UTC) #4
Florian Schneider
4 years, 9 months ago (2016-03-07 16:55:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
21488156739fc99404735624ae70ee9f37c27427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698