Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1773623003:
[driver] output verbose logging from flutter driver (Closed)
Description[driver] output verbose logging from flutter driver
BUG=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299152
Patch Set 1 #Patch Set 2 : allow driver step to fail #Patch Set 3 : remove intentional error #
Messages
Total messages: 37 (17 generated)
yjbanov@google.com changed reviewers: + abarth@google.com, eseidel@chromium.org
The CQ bit was checked by yjbanov@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by eseidel@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by yjbanov@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
eseidel@google.com changed reviewers: + eseidel@google.com
The CQ bit was checked by eseidel@google.com
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from eseidel@chromium.org Link to the patchset: https://codereview.chromium.org/1773623003/#ps40001 (title: "remove intentional error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
iannucci@google.com changed reviewers: + iannucci@google.com
Eric's lgtm should have worked, but for now you can have mine
abarth has had trouble lg'ing too. See crbug.com/591484
agable says there was some sort of announcement on chrome infra? I think you need to join the chrome infra ml to commit in build On Tue, Mar 8, 2016, 10:13 <eseidel@chromium.org> wrote: > abarth has had trouble lg'ing too. See crbug.com/591484 > > https://codereview.chromium.org/1773623003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
I don't see one. I'm on the chrome-infra-team list. Maybe we should take this to a private bug. On Tue, Mar 8, 2016 at 10:30 AM, Robbie Iannucci <iannucci@google.com> wrote: > agable says there was some sort of announcement on chrome infra? I think you > need to join the chrome infra ml to commit in build > > > On Tue, Mar 8, 2016, 10:13 <eseidel@chromium.org> wrote: >> >> abarth has had trouble lg'ing too. See crbug.com/591484 >> >> https://codereview.chromium.org/1773623003/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by eseidel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
iannucci@chromium.org changed reviewers: + iannucci@chromium.org
lgtm for real this time
The CQ bit was checked by eseidel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773623003/40001
Message was sent while issue was closed.
Description was changed from ========== [driver] output verbose logging from flutter driver BUG= ========== to ========== [driver] output verbose logging from flutter driver BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299152 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299152 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
