Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1773613002: Mark some cronet instrumentation tests flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 9e0c8b465f86f06ab64900783f171cf8e96e90d2..ba3ffa32dd0572932ceaa3144e77ce77d0c3c721 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -11,6 +11,7 @@
import android.os.ConditionVariable;
import android.os.Handler;
import android.os.Looper;
+import android.test.FlakyTest;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.PathUtils;
@@ -320,9 +321,13 @@ public void testRequestFinishedListener() throws Exception {
mTestFramework.mCronetEngine.shutdown();
}
+ /*
@SmallTest
@Feature({"Cronet"})
@SuppressWarnings("deprecation")
+ https://crbug.com/592444
+ */
+ @FlakyTest
public void testRequestFinishedListenerFailedRequest() throws Exception {
String connectionRefusedUrl = "http://127.0.0.1:3";
mTestFramework = startCronetTestFramework();
@@ -528,8 +533,12 @@ public void testMultipleShutdown() throws Exception {
}
}
+ /*
@SmallTest
@Feature({"Cronet"})
+ https://crbug.com/592444
+ */
+ @FlakyTest
public void testShutdownAfterError() throws Exception {
mTestFramework = startCronetTestFramework();
TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback();

Powered by Google App Engine
This is Rietveld 408576698