Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1773593007: Move fx_agg_driver files up one level (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move fx_agg_driver files up one level The agg driver files are split into src/ and include/ directories. This CL moves the source files up one level and removes the src/ and include/ directories. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fffc96359b48ca4ac873dc4a109788750ad87899

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1967 lines) Patch
M BUILD.gn View 6 chunks +9 lines, -9 lines 2 comments Download
A + core/src/fxge/agg/fx_agg_driver.h View 4 chunks +6 lines, -4 lines 0 comments Download
A + core/src/fxge/agg/fx_agg_driver.cpp View 34 chunks +46 lines, -2 lines 0 comments Download
D core/src/fxge/agg/include/fx_agg_driver.h View 1 chunk +0 lines, -150 lines 0 comments Download
D core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +0 lines, -1795 lines 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. https://codereview.chromium.org/1773593007/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1773593007/diff/1/BUILD.gn#newcode134 BUILD.gn:134: "third_party:pdfium_base", These are the result of git cl ...
4 years, 9 months ago (2016-03-08 01:57:46 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1773593007/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1773593007/diff/1/BUILD.gn#newcode134 BUILD.gn:134: "third_party:pdfium_base", On 2016/03/08 01:57:46, dsinclair wrote: > These ...
4 years, 9 months ago (2016-03-08 03:44:31 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-08 13:57:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fffc96359b48ca4ac873dc4a109788750ad87899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698