Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1773553003: Removing dependency on js-test.js from shadow-dom.js (Closed)

Created:
4 years, 9 months ago by yuzuchan
Modified:
4 years, 9 months ago
Reviewers:
hayato, kojii, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing dependency on js-test.js from shadow-dom.js This CL removes dependency of shadow-dom.js on js-test.js, namely debug function. BUG=591946 Committed: https://crrev.com/5a49cbd778aef637c586a8ebae8bb2f952d30a09 Cr-Commit-Position: refs/heads/master@{#379777}

Patch Set 1 #

Patch Set 2 : Remove dependency on js-test.js from shadow-dom.js #

Total comments: 2

Patch Set 3 : Add a clarification comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 1 2 2 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/tabindex-slot.html View 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hayato
lgtm https://codereview.chromium.org/1773553003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js File third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js (right): https://codereview.chromium.org/1773553003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js#newcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js:1: // TODO(yuzus): These two functions below need cleaning ...
4 years, 9 months ago (2016-03-08 04:36:47 UTC) #2
yuzuchan
https://codereview.chromium.org/1773553003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js File third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js (right): https://codereview.chromium.org/1773553003/diff/20001/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js#newcode1 third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js:1: // TODO(yuzus): These two functions below need cleaning up. ...
4 years, 9 months ago (2016-03-08 06:48:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773553003/40001
4 years, 9 months ago (2016-03-08 06:48:09 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 07:43:09 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 07:44:19 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5a49cbd778aef637c586a8ebae8bb2f952d30a09
Cr-Commit-Position: refs/heads/master@{#379777}

Powered by Google App Engine
This is Rietveld 408576698