Add source location to function declarations.

Add source location to function declarations.

Temporarily adds source location to function declarations in the new source info system.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/583fd470d8dcc9a7b990483dd74789bfef486f92

[Johnni Winther, 2016-03-07 11:12:23]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-03-07 18:12:49]

lgtm, thanks!

https://codereview.chromium.org/1773553002/diff/1/pkg/compiler/lib/src/io/pos...
File pkg/compiler/lib/src/io/position_information.dart (right):

https://codereview.chromium.org/1773553002/diff/1/pkg/compiler/lib/src/io/pos...
pkg/compiler/lib/src/io/position_information.dart:506: int codeLocation =
offset.subexpressionOffset;
consider moving this out to the beginning of onStep?

  onStep(...) {
    sourceInformation = ...
    if (sourceInformation == null) return;
    int codeLocation = ...;
    if (codeLocation == null) return;

If not, maybe still do the null check before calculating the sourceLocation
below?

[Johnni Winther, 2016-03-08 09:31:16]

Description was changed from

==========
Add source location to function declarations.

Temporarily adds source location to function declarations in the new source info
system.
==========

to

==========
Add source location to function declarations.

Temporarily adds source location to function declarations in the new source info
system.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/583fd470d8dcc9a7b990483dd74789bfef486f92
==========

[Johnni Winther, 2016-03-08 09:31:19]

Committed patchset #3 (id:40001) manually as
583fd470d8dcc9a7b990483dd74789bfef486f92 (presubmit successful).

[Johnni Winther, 2016-03-08 09:39:23]

https://codereview.chromium.org/1773553002/diff/1/pkg/compiler/lib/src/io/pos...
File pkg/compiler/lib/src/io/position_information.dart (right):

https://codereview.chromium.org/1773553002/diff/1/pkg/compiler/lib/src/io/pos...
pkg/compiler/lib/src/io/position_information.dart:506: int codeLocation =
offset.subexpressionOffset;
On 2016/03/07 18:12:49, Siggi Cherem (dart-lang) wrote:
> consider moving this out to the beginning of onStep?
> 
>   onStep(...) {
>     sourceInformation = ...
>     if (sourceInformation == null) return;
>     int codeLocation = ...;
>     if (codeLocation == null) return;
> 
> If not, maybe still do the null check before calculating the sourceLocation
> below? 

Done.