Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1773533002:
MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub (Closed)
|
Created:
4 years, 9 months ago by ivica.bogosavljevic Modified:
4 years, 9 months ago Reviewers:
ilija.pavlovic, balazs.kilvady, miran.karic, Marija Antic, gergely.kis.imgtec, akos.palfi.imgtec CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub
Fixed a few errors in implementation of FastNewObjectStub::Generate
for MIPS64 that cause a hadnfull of tests to fail.
TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations
BUG=
Committed: https://crrev.com/cafe34ae4afbe3495983d615c4b8e1cd3721c4b5
Cr-Commit-Position: refs/heads/master@{#34535}
Patch Set 1 #Patch Set 2 : Rebasing master #
Messages
Total messages: 21 (11 generated)
Executed tests on simulator MIPS64, no regressions. PTAL
Nice, LGTM! Nit: put a period at the end of the sentence in the description.
Description was changed from ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= ========== to ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= ==========
The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2442)
The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773533002/1
The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ivica.bogosavljevic@imgtec.com
The patchset sent to the CQ was uploaded after l-g-t-m from akos.palfi@imgtec.com Link to the patchset: https://codereview.chromium.org/1773533002/#ps20001 (title: "Rebasing master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773533002/20001
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= ========== to ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= ========== to ========== MIPS64: Fix [stubs] Introduce a dedicated FastNewObjectStub Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= Committed: https://crrev.com/cafe34ae4afbe3495983d615c4b8e1cd3721c4b5 Cr-Commit-Position: refs/heads/master@{#34535} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cafe34ae4afbe3495983d615c4b8e1cd3721c4b5 Cr-Commit-Position: refs/heads/master@{#34535} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
