Issue 177353005: Layers view: Extract zoom/pan/rotate logic into transorm controller

Issue 177353005: Layers view: Extract zoom/pan/rotate logic into transorm controller (Closed)

Created:
6 years, 9 months ago by caseq

Modified:
6 years, 9 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Layers view: Extract zoom/pan/rotate logic into transorm controller Also, apply zoom to layer div sizes to keep resulting layers small. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168552

Patch Set 1 #

Total comments: 4

Patch Set 2 : express enum values via bit shifts to make evident it's a mask #

Patch Set 3 : added rounding of layer divs positions and sizes, fixed the test #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -96 lines)			Patch
M	LayoutTests/inspector/layers/layers-panel-mouse-events.html	View	1 2	2 chunks	+9 lines, -10 lines	0 comments	Download
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/Layers3DView.js	View	1 2	10 chunks	+73 lines, -85 lines	0 comments	Download
M	Source/devtools/front_end/LayersPanel.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	Source/devtools/front_end/TransformController.js	View	1 2	1 chunk	+171 lines, -0 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/177353005/diff/1/Source/devtools/devtools.gypi File Source/devtools/devtools.gypi (right): https://codereview.chromium.org/177353005/diff/1/Source/devtools/devtools.gypi#newcode466 Source/devtools/devtools.gypi:466: 'front_end/TransformController.js', This name is too generic. https://codereview.chromium.org/177353005/diff/1/Source/devtools/front_end/TransformController.js File ...

6 years, 9 months ago (2014-03-04 15:55:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/177353005/40001

6 years, 9 months ago (2014-03-05 13:07:30 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/177353005/40001

6 years, 9 months ago (2014-03-05 20:58:18 UTC) #7

Message was sent while issue was closed.

Change committed as 168552

Expand Messages | Collapse Messages