Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: ash/ash.gyp

Issue 177353002: Add use_allocator instead of linux_use_tcmalloc to switch the allocator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready with use_allocator Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/ash.gyp
diff --git a/ash/ash.gyp b/ash/ash.gyp
index fe1b0e09ac73b3d38818e9b61565b7a54b95d1dd..fad9974a743d248d06a3de59fee3068367caa3a6 100644
--- a/ash/ash.gyp
+++ b/ash/ash.gyp
@@ -1026,7 +1026,8 @@
['exclude', 'display/resolution_notification_controller_unittest.cc'],
],
}],
- ['OS=="linux" and component=="shared_library" and linux_use_tcmalloc==1', {
+ # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
darin (slow to review) 2014/03/01 00:38:56 maybe this GYP block would be better as a .gypi th
Dai Mikurube (NOT FULLTIME) 2014/03/01 01:01:19 Sure. Maybe. But actually, it's not trivial since
+ ['OS=="linux" and component=="shared_library" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', {
'dependencies': [
'<(DEPTH)/base/allocator/allocator.gyp:allocator',
],
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698