src/IceAssemblerARM32.h - Issue 1773503003: Subzero: Control memory growth from local label fixups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerARM32.h

Issue 1773503003: Subzero: Control memory growth from local label fixups. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Attempt to fix -nonsfi -filetype=iasm -target=arm32 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerARM32.h

diff --git a/src/IceAssemblerARM32.h b/src/IceAssemblerARM32.h

index 0e95eab327d6589de008339dcdbfb9cd14293f9e..1cf07ad47e9f681b5494e88918e4819f23cbcb69 100644

--- a/src/IceAssemblerARM32.h

+++ b/src/IceAssemblerARM32.h

@@ -160,8 +160,10 @@ public:

}

bool fixupIsPCRel(FixupKind Kind) const override {

- (void)Kind;

- // TODO(kschimpf) Decide if we need this.

+ if (Kind == llvm::ELF::R_ARM_MOVW_PREL_NC)

+ return true;

+ if (Kind == llvm::ELF::R_ARM_MOVT_PREL)

+ return true;

return false;

}

« no previous file with comments | « pydir/crosstest_generator.py ('k') | src/IceAssemblerARM32.cpp » ('j') | no next file with comments »