Subzero: Control memory growth from local label fixups.

src/IceELFSection.h

 //===- subzero/src/IceELFSection.h - Model of ELF sections ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 214 matching lines @@
       : ELFSection(Name, ShType, ShFlags, ShAddralign, ShEntsize),
         RelatedSection(nullptr) {}
 
   const ELFSection *getRelatedSection() const { return RelatedSection; }
   void setRelatedSection(const ELFSection *Section) {
     RelatedSection = Section;
   }
 
   /// Track additional relocations which start out relative to offset 0, but
   /// should be adjusted to be relative to BaseOff.
-  void addRelocations(RelocOffsetT BaseOff, const FixupRefList &FixupRefs);
+  void addRelocations(RelocOffsetT BaseOff, const FixupRefList &FixupRefs,
+                      ELFSymbolTableSection *SymTab);
 
   /// Track a single additional relocation.
   void addRelocation(const AssemblerFixup &Fixup) { Fixups.push_back(Fixup); }
 
   size_t getSectionDataSize() const;
 
   template <bool IsELF64>
   void writeData(ELFStreamer &Str, const ELFSymbolTableSection *SymTab);
 
   bool isRela() const { return Header.sh_type == SHT_RELA; }
@@ skipping 100 matching lines @@
   }
 }
 
 template <bool IsELF64>
 void ELFRelocationSection::writeData(ELFStreamer &Str,
                                      const ELFSymbolTableSection *SymTab) {
   for (const AssemblerFixup &Fixup : Fixups) {
     const ELFSym *Symbol;
     if (Fixup.isNullSymbol()) {
       Symbol = SymTab->getNullSymbol();
+    } else if (Fixup.valueIsSymbol()) {
+      Symbol = Fixup.getSymbolValue();
     } else {
-      constexpr Assembler *Asm = nullptr;
-      const IceString Name = Fixup.symbol(Asm);
+      const IceString Name = Fixup.symbol();
       Symbol = SymTab->findSymbol(Name);
       if (!Symbol)
         llvm::report_fatal_error(Name + ": Missing symbol mentioned in reloc");
     }
 
     if (IsELF64) {
       Elf64_Rela Rela;
       Rela.r_offset = Fixup.position();
       Rela.setSymbolAndType(Symbol->getNumber(), Fixup.kind());
       Rela.r_addend = Fixup.offset();
       Str.writeAddrOrOffset<IsELF64>(Rela.r_offset);
       Str.writeELFXword<IsELF64>(Rela.r_info);
       Str.writeELFXword<IsELF64>(Rela.r_addend);
     } else {
       Elf32_Rel Rel;
       Rel.r_offset = Fixup.position();
       Rel.setSymbolAndType(Symbol->getNumber(), Fixup.kind());
       Str.writeAddrOrOffset<IsELF64>(Rel.r_offset);
       Str.writeELFWord<IsELF64>(Rel.r_info);
     }
   }
 }
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEELFSECTION_H