third_party/WebKit/Source/core/fetch/ImageResource.h - Issue 1773503002: Shortcut ImageResource::canRender()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 1773503002: Shortcut ImageResource::canRender() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.h b/third_party/WebKit/Source/core/fetch/ImageResource.h

index c17849ad11da963117c19fe7663c0aedca164987..afbd05fad9549d3e3d6093e150eea659708f038f 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.h

@@ -71,9 +71,6 @@ public:

static std::pair<blink::Image*, float> brokenImage(float deviceScaleFactor); // Returns an image and the image's resolution scale factor.

bool willPaintBrokenImage() const;

- // Assumes that image rotation or scale doesn't effect the image size being empty or not.

- bool canRender() { return !errorOccurred() && !imageSize(DoNotRespectImageOrientation, 1).isEmpty(); }

bool usesImageContainerSize() const;

bool imageHasRelativeSize() const;

// The device pixel ratio we got from the server for this image, or 1.0.