Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1773473004: Remove references to mojo_public_environment_unittests from build/ (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove references to mojo_public_environment_unittests from build/ This test will be removed soon. BUG=585942 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299163

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M scripts/master/factory/chromium_factory.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yzshen1
Hi, Dirk. Would you please take a look? Thanks!
4 years, 9 months ago (2016-03-07 23:52:56 UTC) #2
yzshen1
On 2016/03/07 23:52:56, yzshen1 wrote: > Hi, Dirk. > > Would you please take a ...
4 years, 9 months ago (2016-03-07 23:55:10 UTC) #3
yzshen1
On 2016/03/07 23:55:10, yzshen1 wrote: > On 2016/03/07 23:52:56, yzshen1 wrote: > > Hi, Dirk. ...
4 years, 9 months ago (2016-03-08 18:50:59 UTC) #4
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-08 23:32:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773473004/20001
4 years, 9 months ago (2016-03-08 23:33:28 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:42:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299163

Powered by Google App Engine
This is Rietveld 408576698