ui/gfx/image/image.h - Issue 1773433002: Fix use-after-free in gfx::Image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/image/image.h

Issue 1773433002: Fix use-after-free in gfx::Image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/image/image.h

diff --git a/ui/gfx/image/image.h b/ui/gfx/image/image.h

index ec05b26d8ffd0e7f45bdd2f4d27ca3fc59afa021..38a5ea9ac2502c95a51b8640fc547587d88207d4 100644

--- a/ui/gfx/image/image.h

+++ b/ui/gfx/image/image.h

@@ -183,7 +183,8 @@ class GFX_EXPORT Image {

internal::ImageRep* GetRepresentation(

RepresentationType rep_type, bool must_exist) const;

- // Stores a representation into the map.

+ // Stores a representation into the map. A representation of that type must

+ // not already be in the map.

void AddRepresentation(scoped_ptr<internal::ImageRep> rep) const;

// Internal class that holds all the representations. This allows the Image to

« no previous file with comments | « no previous file | ui/gfx/image/image.cc » ('j') | no next file with comments »