Issue 177343002: Allow Object::InternalFieldCount and Object::GetAlignedPointerFromInternalField to be called from P…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177343002: Allow Object::InternalFieldCount and Object::GetAlignedPointerFromInternalField to be called from P… (Closed)

Created:
6 years, 10 months ago by dcarney

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Allow Object::InternalFieldCount and Object::GetAlignedPointerFromInternalField to be called from Persistent classes R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19740

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	include/v8.h	View		3 chunks	+13 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, but as discussed offline: If there will be more of these methods, these should ...

6 years, 10 months ago (2014-02-24 08:56:32 UTC) #2

dcarney

6 years, 9 months ago (2014-03-10 08:19:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19740 (presubmit successful).