Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1773423002: Revert of Switch back to open image in new tab where applicable. (Closed)

Created:
4 years, 9 months ago by Benoit L
Modified:
4 years, 9 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch back to open image in new tab where applicable. (patchset #4 id:60001 of https://codereview.chromium.org/1741153002/ ) Reason for revert: Suspected CL for test breakages: org.chromium.chrome.browser.contextmenu.ContextMenuTest#testLongPressOnImage org.chromium.chrome.browser.contextmenu.ContextMenuTest#testLongPressOnImageLink on downstream occam-svelte and android-one. Original issue's description: > Switch back to open image in new tab where applicable. > > open image will remain in CCT as that tries to prevent new > tab creation > > BUG=589275 > > Committed: https://crrev.com/4dba7838c14fff4e36c49045a8c4c2bf72b64b18 > Cr-Commit-Position: refs/heads/master@{#379877} TBR=newt@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589275 Committed: https://crrev.com/aea0d270c480410ad8764473797bbf5b5f6c6189 Cr-Commit-Position: refs/heads/master@{#380125}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Benoit L
Created Revert of Switch back to open image in new tab where applicable.
4 years, 9 months ago (2016-03-09 12:44:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773423002/1
4 years, 9 months ago (2016-03-09 12:44:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 12:45:01 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 12:46:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aea0d270c480410ad8764473797bbf5b5f6c6189
Cr-Commit-Position: refs/heads/master@{#380125}

Powered by Google App Engine
This is Rietveld 408576698