Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1773403005: Fix binutils, gcc, gcc-avr in devenv (after roll). (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Fix binutils, gcc, gcc-avr in devenv (after roll). Binutils regressed by no longer linking against CLI_MAIN libs. Gcc and gcc-avr lost needed ldflags + libs. BUG=None TEST=manual TBR=binji@chromium.org,petewil@chromium.org Committed: https://chromium.googlesource.com/webports/+/d9eb95de83df99552c439d28948b58d800776daf

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ports/binutils-2.25/build.sh View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ports/binutils/build.sh View 1 chunk +1 line, -0 lines 0 comments Download
M ports/gcc-avr/build.sh View 1 chunk +1 line, -0 lines 0 comments Download
M ports/gcc/build.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bradn
4 years, 9 months ago (2016-03-10 02:44:50 UTC) #2
bradn
Will TBR since we're expecting a flurry of interest and it needs to bake on ...
4 years, 9 months ago (2016-03-10 02:59:03 UTC) #4
bradn
But definitely will not skip the CQ, as the "like" change to 2.25 didn't work ...
4 years, 9 months ago (2016-03-10 03:00:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773403005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773403005/20001
4 years, 9 months ago (2016-03-10 03:12:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/webports/+/d9eb95de83df99552c439d28948b58d800776daf
4 years, 9 months ago (2016-03-10 04:44:45 UTC) #9
binji
4 years, 9 months ago (2016-03-10 19:05:02 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698