scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json - Issue 1773363002: Remove build directory before performing perf tryjob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json

Issue 1773363002: Remove build directory before performing perf tryjob. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Relanding this after rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json ('k') | scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json

diff --git a/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json b/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json

index cd5bbaa7d44e63cb70a2ed9715b81040cf11a2d5..48ca7b8a041490e4af59c81f7444c6b7fdd36a2c 100644

--- a/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json

+++ b/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json

@@ -158,6 +158,26 @@

"cmd": [

"python",

"-u",

+ "\nimport os, sys\nfrom common import chromium_utils # Error? See https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n chromium_utils.RemoveDirectory(sys.argv[1])\n",

+ "[SLAVE_BUILD]/src/out/Release"

+ ],

+ "cwd": "[SLAVE_BUILD]",

+ "name": "rmtree build directory",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import os, sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@from common import chromium_utils # Error? See https://crbug.com/584783.@@@",

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]):@@@",

+ "@@@STEP_LOG_LINE@python.inline@ chromium_utils.RemoveDirectory(sys.argv[1])@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[SLAVE_BUILD]/src/tools/mb/mb.py",

"gen",

"-m",