Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1773343002:
Adds views_mus_unittests to the linux bot (Closed)
DescriptionAdds views_mus_unittests to the linux bot
This test has been running on the mojo linux bot for a while now and
is stable:
https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/
BUG=577274
TEST=bot only change
R=dpranke@chromium.org, ben@chromium.org
TBR=ben@chromium.org
Committed: https://crrev.com/ee5428c71af89fa316e7d7f02e759ace6c019481
Cr-Commit-Position: refs/heads/master@{#380550}
Patch Set 1 #
Total comments: 2
Patch Set 2 : swarming #Patch Set 3 : update deps for mus #Patch Set 4 : app resources to data_deps #
Messages
Total messages: 39 (18 generated)
https://codereview.chromium.org/1773343002/diff/1/testing/buildbot/chromium.l... File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/1773343002/diff/1/testing/buildbot/chromium.l... testing/buildbot/chromium.linux.json:930: }, can this run under swarming? If so, you should add the "swarming" clause you see for the other tests. If it can't, that's a problem ...
https://codereview.chromium.org/1773343002/diff/1/testing/buildbot/chromium.l... File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/1773343002/diff/1/testing/buildbot/chromium.l... testing/buildbot/chromium.linux.json:930: }, On 2016/03/09 00:22:00, Dirk Pranke wrote: > can this run under swarming? If so, you should add the "swarming" clause you see > for the other tests. > > If it can't, that's a problem ... AFAIK, yes.
lgtm. If it doesn't work, the tryservers will tell you :).
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
sky@chromium.org changed reviewers: + ben@chromium.org
+ben for changes to components/mus/BUILD.gn and mojo/public/mojo_application.gni The first moves a dep to data_deps, and the second makes resources in mojo_native_application be in the data_deps, not deps. Both of these are trivial, so I'm TBRing Ben for those.
Description was changed from ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org ========== to ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org, ben@chromium.org TBR=ben@chromium.org ==========
The CQ bit was checked by sky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1773343002/#ps60001 (title: "app resources to data_deps")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/60001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773343002/60001
Message was sent while issue was closed.
Description was changed from ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org, ben@chromium.org TBR=ben@chromium.org ========== to ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org, ben@chromium.org TBR=ben@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org, ben@chromium.org TBR=ben@chromium.org ========== to ========== Adds views_mus_unittests to the linux bot This test has been running on the mojo linux bot for a while now and is stable: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/ BUG=577274 TEST=bot only change R=dpranke@chromium.org, ben@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/ee5428c71af89fa316e7d7f02e759ace6c019481 Cr-Commit-Position: refs/heads/master@{#380550} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ee5428c71af89fa316e7d7f02e759ace6c019481 Cr-Commit-Position: refs/heads/master@{#380550} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
